QR code reciprocation #1297
Merged
QR code reciprocation #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this so later we can keep the other user master signing key on it so we can make sure we cross-sign that one once we decide to sign.
so we don't sign the wrong keys if a malicious HS admin forged a cross-sign identity reset
so we can show a different ux now that it's not just SAS anymore, but also reciprocate
Also fix static methods not to use this
(as the phase hasn't been set yet) Also, set the qrCodeData in handleEvent as we need it to be async
bwindels
force-pushed
the
bwindels/qr-reciprocate
branch
from
7eba234 to
43eae49
Compare
foldleft
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This move the generation of the QR code from the react-sdk into the js-sdk. I did this to be able to keep the keys that are being verified attached on the verification request (as we should not read the again from the store when signing), and it also feels like a more natural place to put it.
The qr code data is now exposed on
VerificationRequest.qrCodeDataafter moving into the ready phase if the other party can scan qr codes.qrCodeData.bufferis what needs to go into the QR code.