Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1 identity server fallbacks #1253

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Remove v1 identity server fallbacks #1253

merged 2 commits into from
Mar 10, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live mentioned this pull request Mar 9, 2020
Merged
@turt2live turt2live requested a review from a team March 9, 2020 23:10
foldleft
foldleft approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@foldleft foldleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; maybe file a task to fix the function contract?

@turt2live
Copy link
Member Author

One day we'll upgrade to full TypeScript across the project, do yet another breaking change, and ditch all the callbacks. I think it's tracked somewhere, if not known to everyone.

@turt2live turt2live merged commit 2bfc44b into develop Mar 10, 2020
@turt2live turt2live deleted the travis/remove-v1-identity branch March 10, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foldleft foldleft foldleft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove v1 IS API fallbacks once servers are updated
2 participants
@turt2live @foldleft