Always update tracked users when sharing keys #1733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/matrix-org/element-web-rageshakes/issues/19974
There are some rare cases when room members are not correctly tracked in
OlmMachine
(investigating separately), which is typically triggered bym.room.membership
events. To solve the consequence (rather than the root cause), ensure that we always update tracked users when sharing keys, even if this does not trigger keys query for the current event, but will do so before the next one. In other words if we do indeed have users that are not yet tracked, they will be unable to decrypt at most the current message, but should recieve the key for the next message.