Capture decryption errors (PSG-1023) #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfogrillo
changed the title
Anderas
reviewed
Jan 4, 2023
| @@ -52,6 +52,7 @@ public class PollAggregator { | |||
|
|
|||
| private var events: [MXEvent] = [] | |||
| private var hasBeenEdited = false | |||
| private var relatedErroredEvents: Set<String> = [] | |||
There was a problem hiding this comment.
Optional: Errored does seem to be grammatical, though I find it a bit unusual and almost looks like a typo. Maybe Failed would be better? Alternatively if this only captures decryption errors, it could even be relatedUndecryptableEvents
There was a problem hiding this comment.
Yeah, it capture just crypto errors.
relatedUndecryptableEvents looks better. ;-)
There was a problem hiding this comment.
Applied -> 7a29bc6
Anderas
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a logic to consider events not decrypted inside a
PollAggregator.The final goal is to warn the user when a poll is affected by decryption errors since otherwise the votes count may be different across sessions of the same user or different users in the same room.
Related PR: element-hq/element-ios#7206