Fail launch when unavailable crypto #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/mandatory_crypto
branch
from
8be47c0
to
8fc862e
Compare
Anderas
requested review from
a team and
gileluard
and removed request for
a team
Anderas
force-pushed
the
andy/mandatory_crypto
branch
from
8fc862e
to
779cf69
Compare
Codecov ReportBase: 25.33% // Head: 25.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1646 +/- ##
===========================================
- Coverage 25.33% 25.32% -0.01%
===========================================
Files 587 587
Lines 92790 92808 +18
Branches 40238 40248 +10
===========================================
- Hits 23510 23508 -2
- Misses 68503 68520 +17
- Partials 777 780 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Anderas
force-pushed
the
andy/mandatory_crypto
branch
from
42887ce
to
c9d7bfa
Compare
Anderas
force-pushed
the
andy/mandatory_crypto
branch
from
c9d7bfa
to
f73c550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail sync / session init when
cryptomodule is required but unavailable. This can happen for instance when we fail to open the underlying database.Previously this would just silently fail and continue syncing forever, now we propagate the error upwards and can display an error.