Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional content in voice message #1595

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Oct 4, 2022

Voice broadcast feature is based on voice message. We need to add some parameters in the content to distinguish them.  

@yostyle yostyle force-pushed the yostyle/voice_message_with_additionnal_content branch from b6842b4 to 19bc92b Compare October 4, 2022 12:29
@yostyle yostyle marked this pull request as ready for review October 4, 2022 12:32
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 13.50% // Head: 13.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (19bc92b) compared to base (7934ebc).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 19bc92b differs from pull request most recent head c8b92e7. Consider uploading reports for the commit c8b92e7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1595      +/-   ##
===========================================
- Coverage    13.50%   13.49%   -0.01%     
===========================================
  Files          541      541              
  Lines        86579    86594      +15     
  Branches     36780    36783       +3     
===========================================
  Hits         11689    11689              
- Misses       74448    74463      +15     
  Partials       442      442              
Impacted Files Coverage Δ
MatrixSDK/Contrib/Swift/Data/MXRoom.swift 0.00% <0.00%> (ø)
MatrixSDK/Data/MXRoom.m 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle merged commit 4d1c50a into develop Oct 4, 2022
@yostyle yostyle deleted the yostyle/voice_message_with_additionnal_content branch October 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants