Remove partialTextMessage support #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change @ismailgulek or @manuroe shouldn't we just keep it? |
|
We can safely put this change on hold, as it is not really required for the fix on mention pills |
Thanks for asking. It is fine by me to remove this method that was marked as deprecated a long time ago. Plus, having a single method to store this data would avoid bugs in the app like the one linked by @aringenbach. |
gileluard
approved these changes
Sep 16, 2022
aringenbach
deleted the
aringenbach/6670_mention_pills_partial_text_message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the support for MXRoom's partialTextMessage as it has been deprecated for a few months now and since it's usage was the root cause of issue element-hq/element-ios#6670
Part of element-hq/element-ios#6671