Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark MXRestClient init as required for mocking. #1484

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

pixlwave
Copy link
Member

In order to add a protocol that includes the client's init, this PR marks it as required. Part of
element-hq/element-ios#6179

@pixlwave pixlwave requested review from a team and MaximeEvrard42 and removed request for a team May 31, 2022 18:12
@pixlwave pixlwave force-pushed the doug/6179_mock_auth_client branch from 1259317 to 5692b88 Compare May 31, 2022 18:30
Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@pixlwave pixlwave merged commit 868fd96 into develop Jun 6, 2022
@pixlwave pixlwave deleted the doug/6179_mock_auth_client branch June 6, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants