MXThreadingService: Add thread creation delegate method #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
approved these changes
Feb 24, 2022
| @objc optional func threadingServiceDidUpdateThreads(_ service: MXThreadingService) | ||
|
|
||
| /// Delegate method to be called when a new local thread is created | ||
| @objc optional func threadingService(_ service: MXThreadingService, |
There was a problem hiding this comment.
I can't quite wrap my head around the concept of direction for a newly created thread. Does new imply empty? And if so, how is direction used?
There was a problem hiding this comment.
It's actually a similar logic with a message, either you get it live, or you can see a new event coming from the server when back paginating. A thread is also the same, either it's created by a live event, or it's recreated by some old events when back paginating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
MXThreadingServiceDelegateby adding a new method for thread creation, with adirectionproperty.