Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix directRooms array argument is not an NSArray exception #1371

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ferologics
Copy link
Contributor

This exception would occur when event.content has exactly one direct room and MXJSONModelSetDictionary converts it to an NSString and not an NSArray.

Signed-off-by: Frantisek Hetes [email protected]

ferologics and others added 2 commits February 16, 2022 10:50
This exception would occur when event.content has exactly one direct room and MXJSONModelSetDictionary converts it to an NSString and not an NSArray
@stefanceriu stefanceriu self-assigned this Mar 1, 2022
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I think we need to do this whole dance right after the MXJSONModelSetDictionary and before the comparisons in order for them to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants