Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose missing Jingle headers in umbrella header #1308

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

ferologics
Copy link
Contributor

@ferologics ferologics commented Nov 30, 2021

Expose missing Jingle headers in umbrella header

Signed-off-by: Frantisek Hetes [email protected]

@ferologics
Copy link
Contributor Author

Context: While adapting the Jingle extension that builds on top of MatrixSDK we needed to expose the missing headers
image

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ferologics, looks good to me 👍

@pixlwave pixlwave merged commit edbb0bb into matrix-org:develop Dec 10, 2021
@ferologics
Copy link
Contributor Author

@pixlwave thanks a bunch for merging! After further testing I've found an issue with missing symbols for MXCallKitAdapter due to the lack of #import "TargetConditionals.h". I opened a PR #1320 for that as well 🙂

@ferologics ferologics deleted the jingle-patch branch December 10, 2021 13:17
@pixlwave pixlwave mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants