Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration from schema <= 12 to schema > 16. Issue #1282 #1284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

N-Pex
Copy link
Contributor

@N-Pex N-Pex commented Nov 3, 2021

Signed-off-by: N-Pex [email protected]

Pull Request Checklist

@pixlwave
Copy link
Member

Thanks for the PR @N-Pex and sorry for the long delay in reviewing. This looks good to me, although there is one small tweak we could make:

  • It would make more sense to wrap the entire enumerateObjects call in the new if block, as there is no need to run this step if it's not going to perform any actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants