This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
MXKRoomBubbleCellDataStoring: Introduce target user ID, display name and avatar URL for room membership events #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and avatar URL for room membership events As reported in vector-im/element-ios/#4102, collapsed membership changes in the Element iOS app currently _always_ display the sender avatar. In contrast, the Element web app shows the avatar of the user whose membership has changed in this case. This commit introduces new properties `targetId`, `targetDisplayName`, `targetAvatarUrl` and `targetAvatarPlaceholder` on `MXKRoomBubbleCellDataStoring`. The values are populated from the event (in case it is an `m.room.member` event) in the initializer of `MXKRoomBubbleCellData` (where the corresponding sender properties are already being assigned). This way, clients can easily choose to present the target avatar instead of the sender avatar when processing the bubble data. Note that the "target" terminology was taken over from matrix-js-sdk which populates the `target` property on `MatrixEvent` objects when they are added to the timeline. Signed-off-by: Johannes Marbach <[email protected]>
Johennes
added a commit
to Johennes/element-ios
that referenced
this pull request
Mar 25, 2021
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in element-hq#4102. Depends on: matrix-org/matrix-ios-kit#793 Signed-off-by: Johannes Marbach <[email protected]>
This was referenced Mar 25, 2021
Johennes
added a commit
to Johennes/element-ios
that referenced
this pull request
Mar 26, 2021
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in element-hq#4102. Depends on: matrix-org/matrix-ios-kit#793 Signed-off-by: Johannes Marbach <[email protected]>
|
This is awesome. Thanks! |
stefanceriu
pushed a commit
to element-hq/element-ios
that referenced
this pull request
Feb 7, 2022
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in #4102. Depends on: matrix-org/matrix-ios-kit#793 Signed-off-by: Johannes Marbach <[email protected]>
stefanceriu
pushed a commit
to element-hq/element-ios
that referenced
this pull request
Feb 7, 2022
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in #4102. Depends on: matrix-org/matrix-ios-kit#793 Signed-off-by: Johannes Marbach <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in element-hq/element-ios#4102, collapsed membership changes in the Element iOS app currently always display the sender avatar. In contrast, the Element web app shows the avatar of the user whose membership has changed in this case.
This commit introduces new properties
targetId,targetDisplayName,targetAvatarUrlandtargetAvatarPlaceholderonMXKRoomBubbleCellDataStoring. The values are populated from the event (in case it is anm.room.memberevent) in the initializer ofMXKRoomBubbleCellData(where the corresponding sender properties are already being assigned). This way, clients can easily choose to present the target avatar instead of the sender avatar when processing the bubble data.Note that the "target" terminology was taken over from matrix-js-sdk which populates the
targetproperty onMatrixEventobjects when they are added to the timeline.Signed-off-by: Johannes Marbach [email protected]
Pull Request Checklist