Groups: Display flair for users in room history. #395
Conversation
MXKRoomDataSource: Force a refresh on flair settings change. MXKRoomBubbleCellData: keep update the flair of the sender. MXKRoomBubbleTableViewCell: Display the sender flair if any TODO: display the full flair list when the user clicks on the displayed flair. element-hq/riot-meta#118
| } | ||
|
|
||
| // Observe any change on publicised groups for the message sender | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didMXSessionUpdatePublicisedGroupsForUsers:) name:kMXSessionDidUpdatePublicisedGroupsForUsersNotification object:self.mxSession]; |
There was a problem hiding this comment.
Is there a mechanism to refresh the sender flair if the room has been added to a group while the app was in background?
I ask for this particular use case because of the group API design, we only update group data only when the app comes back to foreground.
There was a problem hiding this comment.
@manuroe: the rooms added to a group are ignored for the moment in the flair process.
Flair takes into account only the related groups defined in room settings and the publicised groups in the user's profile.
| if (MXTimelineDirectionForwards == direction) | ||
| { | ||
| // The flair settings have been updated: flush the current bubble data and rebuild them. | ||
| [self reload]; |
There was a problem hiding this comment.
is it the answer to my question in the other comment?
There was a problem hiding this comment.
Not really, here we detect that the related groups have been updated. We reload the data source because all the room bubbles have to update their sender flair.
MXKRoomDataSource: Force a refresh on flair settings change.
MXKRoomBubbleCellData: keep update the flair of the sender.
MXKRoomBubbleTableViewCell: Display the sender flair if any
TODO: display the full flair list when the user clicks on the displayed flair.
element-hq/riot-meta#118