Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MSC2409 #32

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Add support for MSC2409 #32

merged 3 commits into from
Oct 8, 2020

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot mentioned this pull request Oct 1, 2020
Merged
@Half-Shot Half-Shot mentioned this pull request Oct 1, 2020
Merged
@Half-Shot Half-Shot requested review from a team and jaller94 and removed request for a team October 1, 2020 15:16
jaller94
jaller94 approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good.
I wonder if we need to check user input more often to ensure the bridge won't hang on giant arrays, strings or whatever. (but that can also be discussed separately from this PR)

src/app-service.ts Show resolved Hide resolved
src/app-service.ts Show resolved Hide resolved
@Half-Shot Half-Shot merged commit f5ed117 into master Oct 8, 2020
@Half-Shot Half-Shot deleted the hs/ephemeral branch July 20, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94