Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESLint warnings #1289

Merged
merged 7 commits into from
Apr 15, 2021
Merged

Fix ESLint warnings #1289

merged 7 commits into from
Apr 15, 2021

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Apr 13, 2021 •
edited
Loading

Includes #1288 which should get reviewed first.

4 non-trivial issues remain

/home/jaller94/Git/matrix-appservice-irc/src/datastore/postgres/PgDataStore.ts
  133:43  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  269:9   warning  'allowUnset' is defined but never used    @typescript-eslint/no-unused-vars
  499:49  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  505:35  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion

@jaller94 jaller94 requested a review from a team April 13, 2021 18:05
@jaller94 jaller94 changed the title Fix ESLint warnings in files only recently linted Fix ESLint warnings Apr 13, 2021
@jaller94 jaller94 mentioned this pull request Apr 13, 2021
Merged
@Half-Shot Half-Shot mentioned this pull request Apr 15, 2021
Closed
Half-Shot
Half-Shot approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look okay to me

@jaller94 jaller94 merged commit f75faed into develop Apr 15, 2021
@jaller94 jaller94 deleted the j94/fix-more-eslint-warnings branch April 15, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaller94 @Half-Shot