Add external sasl with with key/cert (tested on freenode) #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco149
force-pushed
the
external-sasl
branch
from
5ce20d2
to
a43d7bf
Compare
Half-Shot
requested changes
Aug 10, 2020
Francesco149
force-pushed
the
external-sasl
branch
from
a43d7bf
to
3407926
Compare
|
i added the check and rebased to develop. not tested but only the 3 line check for the password and the node-irc commit hash have changed |
Francesco149
force-pushed
the
external-sasl
branch
from
3407926
to
8a63162
Compare
|
rebased again, tested on freenode and can confirm it works great |
Half-Shot
requested changes
Sep 4, 2020
There was a problem hiding this comment.
Code looks fine, but CI needs fixing (check the tests and linting). You'll also need to sign off as per https://github.com/matrix-org/matrix-appservice-irc/blob/develop/CONTRIBUTING.md#making-pull-requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this requires matrix-org/node-irc#48 to be merged to build correctly (it references that commit in the package-lock)
this allows authenticating through sasl external on services like freenode by specifying cert and key and setting saslMode to EXTERNAL. tested on freenode from my ec2 instance
see the node-irc pull for more info
this also gets around the issue of having a hardcoded bot name since the external auth on freenode doesn't care if your nickname matches