Added ability to set fallback encoding for non-UTF-8 strings. Implements #580. #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Apr 27, 2020
src/irc/ClientPool.ts
Outdated
| @@ -289,7 +291,8 @@ export class ClientPool { | |||
|
|
|||
| return new BridgedClient( | |||
| server, ircClientConfig, matrixUser || undefined, isBot, | |||
| this.ircEventBroker, this.identGenerator, this.ipv6Generator | |||
| this.ircEventBroker, this.identGenerator, this.ipv6Generator, | |||
| this.encodingFallback | |||
There was a problem hiding this comment.
Would prefer it if we just did:
this.ircBridge.config.ircService.encodingFallback rather than copying it to ClientPool
There was a problem hiding this comment.
That's right. Fixed now.
|
Fixes #580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: To actually work this requires node-irc with this PR merged matrix-org/node-irc#43
I haven't written much NodeJS so please review the changes properly and let me know if any changes are needed.
Signed-off-by: Ville Ranki [email protected]