-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long quotes in replies #1521
Comments
That looks more like @jesopo quoted a message rather than a reply? |
I found another example: {
"content": {
"body": "> <@ilmari:ilmari.org> I tried to join now, and my HS logged this: \n> ```\n> 2022-05-31 13:16:37,121 - synapse.util.retryutils - 222 - INFO - POST-1985617- Connection to matrix.org was unsuccessful (<class 'synapse.api.errors.RequestSendFailed'>(Failed to send request: ResponseNeverReceived: [<twisted.python.failure.Failure twisted.internet.error.ConnectionLost: Connection to the other side was lost in a non-clean fashion: Connection lost.>])); backoff now 600000\n> 2022-05-31 13:16:37,121 - synapse.federation.federation_client - 683 - WARNING - POST-1985617- Failed to send_join via matrix.org: Failed to send request: ResponseNeverReceived: [<twisted.python.failure.Failure twisted.internet.error.ConnectionLost: Connection to the other side was lost in a non-clean fashion: Connection lost.>]\n> 2022-05-31 13:16:37,122 - synapse.http.server - 95 - INFO - POST-1985617- <XForwardedForRequest at 0x7f44969d8cd0 method='POST' uri='/_matrix/client/r0/join/%23_oftc_%23debian%3Amatrix.org' clientproto='HTTP/1.0' site='8008'> SynapseError: 502 - Failed to send_join via any server\n> 2022-05-31 13:16:37,125 - synapse.access.http.8008 - 427 - INFO - POST-1985617- 152.37.111.239 - 8008 - {@ilmari:ilmari.org} Processed request: 125.448sec/0.002sec (0.020sec, 0.002sec) (0.012sec/0.050sec/5) 68B 502 \"POST /_matrix/client/r0/join/%23_oftc_%23debian%3Amatrix.org HTTP/1.0\" \"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0\" [0 dbevts]\n> ```\n\nfederation will initially fail to join massive rooms regardless if they are bridged or not ",
"format": "org.matrix.custom.html",
"formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!pSjsXGiqgurMQWoWnf:half-shot.uk/$Ui7cHVM0Xz-xHeQ1DhLHhvDQqs9H_LJTgWasonKrcVA\">In reply to</a> <a href=\"https://matrix.to/#/@ilmari:ilmari.org\">@ilmari:ilmari.org</a><br><p>I tried to join now, and my HS logged this:</p>\n<pre><code>2022-05-31 13:16:37,121 - synapse.util.retryutils - 222 - INFO - POST-1985617- Connection to matrix.org was unsuccessful (<class 'synapse.api.errors.RequestSendFailed'>(Failed to send request: ResponseNeverReceived: [<twisted.python.failure.Failure twisted.internet.error.ConnectionLost: Connection to the other side was lost in a non-clean fashion: Connection lost.>])); backoff now 600000\n2022-05-31 13:16:37,121 - synapse.federation.federation_client - 683 - WARNING - POST-1985617- Failed to send_join via matrix.org: Failed to send request: ResponseNeverReceived: [<twisted.python.failure.Failure twisted.internet.error.ConnectionLost: Connection to the other side was lost in a non-clean fashion: Connection lost.>]\n2022-05-31 13:16:37,122 - synapse.http.server - 95 - INFO - POST-1985617- <XForwardedForRequest at 0x7f44969d8cd0 method='POST' uri='/_matrix/client/r0/join/%23_oftc_%23debian%3Amatrix.org' clientproto='HTTP/1.0' site='8008'> SynapseError: 502 - Failed to send_join via any server\n2022-05-31 13:16:37,125 - synapse.access.http.8008 - 427 - INFO - POST-1985617- 152.37.111.239 - 8008 - {@ilmari:ilmari.org} Processed request: 125.448sec/0.002sec (0.020sec, 0.002sec) (0.012sec/0.050sec/5) 68B 502 "POST /_matrix/client/r0/join/%23_oftc_%23debian%3Amatrix.org HTTP/1.0" "Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0" [0 dbevts]\n</code></pre>\n</blockquote></mx-reply>federation will initially fail to join massive rooms regardless if they are bridged or not",
"m.relates_to": {
"m.in_reply_to": {
"event_id": "$Ui7cHVM0Xz-xHeQ1DhLHhvDQqs9H_LJTgWasonKrcVA"
}
},
"msgtype": "m.text"
},
"origin_server_ts": 1654003301663,
"sender": "@hifi:vi.fi",
"type": "m.room.message",
"unsigned": {},
"event_id": "$qpiDW1-Ad-8vaO-VvEjvG79DAr_rsVOfVPw3FmAy5EI",
"room_id": "!pSjsXGiqgurMQWoWnf:half-shot.uk"
} gives this on IRC:
and the pastebin's content is:
|
Just got a better example without pastebining or markdown: {
"content": {
"body": "> <@ilynica:matrix.org> Hello! So I’m new to this matrix thing with Literally Zero knowledge about programming and terminologies. like nada. like a kid who doesn’t even know what a cpu is lol\n> But I do plan on building a community here for all of my subscribers from patreon. My question is, is it possible to have a room without letting anyone see the participant list, and not letting anyone dm each other?\n> I want to keep old patrons who cancelled and prevent them from begging other patrons to share early access content for free lol\n\nthere's no way currently to do that and it would probably be pretty difficult to get that working with how matrix works to my knowledge (I dont fully understand it so dont quote me on that lmao) just generally from what I've seen people who know it more then me say ",
"format": "org.matrix.custom.html",
"formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!OGEhHVWSdvArJzumhm:matrix.org/$l0lzyEnSVhLBAh3fmPW3DcxIO6paHDO2yYJx8ASYrDw?via=matrix.org&via=libera.chat&via=wolfo.tech\">In reply to</a> <a href=\"https://matrix.to/#/@ilynica:matrix.org\">@ilynica:matrix.org</a><br>Hello! So I’m new to this matrix thing with Literally Zero knowledge about programming and terminologies. like nada. like a kid who doesn’t even know what a cpu is lol<br/>But I do plan on building a community here for all of my subscribers from patreon. My question is, is it possible to have a room without letting anyone see the participant list, and not letting anyone dm each other?<br/>I want to keep old patrons who cancelled and prevent them from begging other patrons to share early access content for free lol</blockquote></mx-reply>there's no way currently to do that and it would probably be pretty difficult to get that working with how matrix works to my knowledge (I dont fully understand it so dont quote me on that lmao) just generally from what I've seen people who know it more then me say",
"m.relates_to": {
"m.in_reply_to": {
"event_id": "$l0lzyEnSVhLBAh3fmPW3DcxIO6paHDO2yYJx8ASYrDw"
}
},
"msgtype": "m.text",
"org.matrix.msc1767.message": [
{
"body": "> <@ilynica:matrix.org> Hello! So I’m new to this matrix thing with Literally Zero knowledge about programming and terminologies. like nada. like a kid who doesn’t even know what a cpu is lol\n> But I do plan on building a community here for all of my subscribers from patreon. My question is, is it possible to have a room without letting anyone see the participant list, and not letting anyone dm each other?\n> I want to keep old patrons who cancelled and prevent them from begging other patrons to share early access content for free lol\n\nthere's no way currently to do that and it would probably be pretty difficult to get that working with how matrix works to my knowledge (I dont fully understand it so dont quote me on that lmao) just generally from what I've seen people who know it more then me say ",
"mimetype": "text/plain"
},
{
"body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!OGEhHVWSdvArJzumhm:matrix.org/$l0lzyEnSVhLBAh3fmPW3DcxIO6paHDO2yYJx8ASYrDw?via=matrix.org&via=libera.chat&via=wolfo.tech\">In reply to</a> <a href=\"https://matrix.to/#/@ilynica:matrix.org\">@ilynica:matrix.org</a><br>Hello! So I’m new to this matrix thing with Literally Zero knowledge about programming and terminologies. like nada. like a kid who doesn’t even know what a cpu is lol<br/>But I do plan on building a community here for all of my subscribers from patreon. My question is, is it possible to have a room without letting anyone see the participant list, and not letting anyone dm each other?<br/>I want to keep old patrons who cancelled and prevent them from begging other patrons to share early access content for free lol</blockquote></mx-reply>there's no way currently to do that and it would probably be pretty difficult to get that working with how matrix works to my knowledge (I dont fully understand it so dont quote me on that lmao) just generally from what I've seen people who know it more then me say",
"mimetype": "text/html"
}
]
},
"origin_server_ts": 1654026332442,
"sender": "@ninchuka:envs.net",
"type": "m.room.message",
"unsigned": {},
"event_id": "$ocE6sxY5_6GEgt3wC3xGapZTFx60oZWtF8-W8pfsark",
"room_id": "!OGEhHVWSdvArJzumhm:matrix.org"
} shows on IRC like this:
|
It seems some messages in particular cause fallbacks to be sent for anyone replying to it. example from #matrix on libera:
I don't see anything weird in the original message, though: {
"content": {
"body": "Hi guys. Does anyone know if there is some software or service for helpdesk with matrix support or a bridge for it?\nI want to propose matrix for corporate communication at my job and it would be one of the reasons to use it.\nOur support uses jivo chat and it has an API, but I doubt I will get funding to develop our own bridge",
"format": "org.matrix.custom.html",
"formatted_body": "Hi guys. Does anyone know if there is some software or service for helpdesk with matrix support or a bridge for it?<br />I want to propose matrix for corporate communication at my job and it would be one of the reasons to use it.<br />Our support uses jivo chat and it has an API, but I doubt I will get funding to develop our own bridge",
"msgtype": "m.text"
},
"origin_server_ts": 1658249905612,
"sender": "@dpprpl:matrix.org",
"type": "m.room.message",
"unsigned": {
"age": 27519
},
"event_id": "$NhKC9OtnlfGJJi-KARnDsU0TdfNuq7B31Ydjr-fNEKE",
"room_id": "!OGEhHVWSdvArJzumhm:matrix.org"
} |
Actually it is pretty easy to reproduce, one just needs to send "foo\nbar" as a message and reply "baz". On the Matrix side, this gives: {
"content": {
"body": "foo\nbar",
"msgtype": "m.text",
"org.matrix.msc1767.text": "foo\nbar"
},
"origin_server_ts": 1660047285973,
"sender": "@pinkie:matrix.org",
"type": "m.room.message",
"unsigned": {
"age": 119,
"transaction_id": "m1660047285785.2"
},
"event_id": "$h0DORYmWAeEXWhnmvQNOJYUjm75dzi1YMWLsVqEDtjg",
"room_id": "!RPsqPQfSxxItkiItKd:libera.chat"
} followed by {
"content": {
"body": "> <@pinkie:matrix.org> foo\n> bar\n\nbaz",
"format": "org.matrix.custom.html",
"formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!RPsqPQfSxxItkiItKd:libera.chat/$h0DORYmWAeEXWhnmvQNOJYUjm75dzi1YMWLsVqEDtjg?via=libera.chat&via=matrix.org\">In reply to</a> <a href=\"https://matrix.to/#/@pinkie:matrix.org\">@pinkie:matrix.org</a><br>foo<br/>bar</blockquote></mx-reply>baz",
"m.relates_to": {
"m.in_reply_to": {
"event_id": "$h0DORYmWAeEXWhnmvQNOJYUjm75dzi1YMWLsVqEDtjg"
}
},
"msgtype": "m.text",
"org.matrix.msc1767.message": [
{
"body": "> <@pinkie:matrix.org> foo\n> bar\n\nbaz",
"mimetype": "text/plain"
},
{
"body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!RPsqPQfSxxItkiItKd:libera.chat/$h0DORYmWAeEXWhnmvQNOJYUjm75dzi1YMWLsVqEDtjg?via=libera.chat&via=matrix.org\">In reply to</a> <a href=\"https://matrix.to/#/@pinkie:matrix.org\">@pinkie:matrix.org</a><br>foo<br/>bar</blockquote></mx-reply>baz",
"mimetype": "text/html"
}
]
},
"origin_server_ts": 1660047289826,
"sender": "@pinkie:matrix.org",
"type": "m.room.message",
"unsigned": {
"age": 665,
"transaction_id": "m1660047289403.3"
},
"event_id": "$OWp5yajpZqxr50kr7fNWgd_B6Mu_GfCZsaJh2fUFu_A",
"room_id": "!RPsqPQfSxxItkiItKd:libera.chat"
} and on the IRC side:
|
By the way, when the first message has two newlines, it sends this to IRC:
(the empty line is omitted from the original message, but not from the fallback in the reply) |
This issue is still reproducible today:
On matrix side:
followed by
|
Hello, I did some investigation on this issue. In
The
but doesn't match this:
Hence, why the end result that's sent on IRC is:
|
Fixes matrix-org#1521 Signed-off-by: Ferass El Hafidi <[email protected]>
Fixes matrix-org#1521 Signed-off-by: Ferass El Hafidi <[email protected]>
Fixes matrix-org#1521 Signed-off-by: Ferass El Hafidi <[email protected]>
Fixes matrix-org#1521 Signed-off-by: Ferass El Hafidi <[email protected]>
Fixes #1521 Signed-off-by: Ferass El Hafidi <[email protected]>
Describe the bug
Seen earlier today (10:42 UTC) on #matrix-irc on Libera
To Reproduce
No idea. Possibly just replying to a multi-line message.
Expected behavior
Should probably be just this:
The text was updated successfully, but these errors were encountered: