This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
force-pushed
the
feature/openId_cleanup
branch
from
August 30, 2019 10:05
f160a1f
to
4b6da8c
Compare
BillCarsonFr
force-pushed
the
feature/openId_cleanup
branch
from
September 17, 2019 14:02
ada967e
to
9738300
Compare
- handle MatrixError correctly - Add v2 API request, with fallback to v1 API - Add some Javadoc with link to the identity server API spec
…manage MatrixError. Use RestAdapterCallback instead.
…cceptIdentityAccessToken() methods.
…he account data which has been updated.
Generate token if needed in order to agree to terms
+ add is params for msisdn token request/validation
BillCarsonFr
force-pushed
the
feature/openId_cleanup
branch
from
September 24, 2019 14:05
441ed26
to
64d5b9e
Compare
bmarty
commented
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM So far
@@ -0,0 +1,11 @@ | |||
package org.matrix.androidsdk.rest.model; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add missing copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/riot-android#3256
This PR is here to expose what has been done so far on Android for the privacy sprint, and ensure that the CI is happy with what we push on the branch