This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Push Notifications #1842
Implement Push Notifications #1842
Changes from all commits
151d52c
2db65e1
bd9a4f5
cb10d9c
c6b3048
d8c8bfc
f5d8f0e
0548a88
54ece78
9262526
ce1255e
74b74bf
bbf4b70
1dbcd84
5ccfe77
b89da40
c9e94b4
da437f0
394ea6b
192e9db
87dc8c7
2582a05
8ee18cd
b01b918
81b71da
8d5426a
23d175d
b20bbc8
0cd3b5c
857b75d
d96623f
fa7d249
6d63096
0d928c6
6ad6b9d
4ce5fec
1aa25b3
3a4add0
a57ce77
26f20d5
f7a4825
dd2518c
977d6b8
4d71df8
67ef8e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
util.GetLogger(req.Context())
would be better as it would have request IDs associated with it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you doing this? Needs comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally have a layer of indirection where we go from Matrix specification structs to internal API structs as they may not always match up and can become error-prone (it's generally safe to assume specification structs needs validation whereas internal API structs do not). It would be nice to do the same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this validation could be part of a struct function for
pushserverapi.PerformPusherSetRequest
which would help tidy this function up a bit.