Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Commit

Permalink
Backup and restore go.mod & go.sum during linting (#735)
Browse files Browse the repository at this point in the history
Every time before sending a PR I like to run ./scripts/build-test-lint.sh to make sure the CI won't complain about anything.

The problem is that this script attempts to install golangci-lint, which causes modifications to go.mod/go.sum. This PR backs up and restores those files before and after linting.

Ideally instead of this hacky backing up/restoring we'd use go gets -mod=readonly option, but that still modifies go.sum. This will be fixed in go 1.13 apparently. golang/go#30667
  • Loading branch information
anoadragon453 authored Jul 12, 2019
1 parent 86e65bb commit d4918b8
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions scripts/find-lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ then args="--fast"
fi

echo "Installing golangci-lint..."

# Make a backup of go.{mod,sum} first
# TODO: Once go 1.13 is out, use go get's -mod=readonly option
# https://github.com/golang/go/issues/30667
cp go.mod go.mod.bak && cp go.sum go.sum.bak
go get github.com/golangci/golangci-lint/cmd/golangci-lint

echo "Looking for lint..."
golangci-lint run $args

# Restore go.{mod,sum}
mv go.mod.bak go.mod && mv go.sum.bak go.sum

0 comments on commit d4918b8

Please sign in to comment.