Use stable prefixes / endpoints for knocking. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See matrix-org/synapse#10167 for the corresponding Synapse PR. |
anoadragon453
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
I chose not to remove the build flag since it allows servers to opt into it being enabled.
As the MSC is merged to the spec now, we should probably remove this build tag (and update the file name) and have homeserver implementations blacklist the tests instead.
That said, it should probably happen in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates knocking tests to use stable:
I chose not to remove the build flag since it allows servers to opt into it being enabled.