Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin coverage again #23135

Merged
merged 2 commits into from
May 25, 2022
Merged

Unpin coverage again #23135

merged 2 commits into from
May 25, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 25, 2022

PR Summary

The upstream issue [1] has been fixed and released in 6.4.

[1] nedbat/coveragepy#1310

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic
Unpin coverage again
cade06d 
The upstream issue [1] has been fixed and release in 6.4.

[1] nedbat/coveragepy#1310
@QuLogic QuLogic added this to the v3.6.0 milestone May 25, 2022
tacaswell
tacaswell approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @oscargus suggestion. unpinning will work fine on CI, but might confuse some people who have an env with 6.3 in it that they then use this file to fillout for testing.

Anyone can merge on CI green.

@tacaswell tacaswell merged commit c2fdd21 into matplotlib:main May 25, 2022
@QuLogic QuLogic deleted the unpin-coverage branch May 25, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Maintenance topic: testing
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @oscargus