Create config for pre-commit and autoformatters+flake8 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Not enabled yet. But once enabled a close + reopen should trigger it |
|
It should be enabled now, triggering CI |
martinRenou
reviewed
Sep 27, 2021
| rev: v2.19.0 | ||
| hooks: | ||
| - id: pyupgrade | ||
| args: [--py37-plus] |
There was a problem hiding this comment.
Is it possible to do the same for eslint and prettier?
There was a problem hiding this comment.
ianhi
force-pushed
the
py-style
branch
4 times, most recently
from
72222db
to
fabb819
Compare
ianhi
commented
Sep 27, 2021
.pre-commit-config.yaml
Outdated
Comment on lines
41
to
42
| additional_dependencies: | ||
| - "@typescript-eslint/eslint-plugin" |
There was a problem hiding this comment.
I think I need to add more things here before merging. not sure i got this right yet.
ianhi
force-pushed
the
py-style
branch
4 times, most recently
from
a625167
to
87d2825
Compare
ianhi
force-pushed
the
py-style
branch
3 times, most recently
from
ae9103a
to
c9244b4
Compare
for more information, see https://pre-commit.ci
|
Only took 11 force pushes :) but we got there |
Closed
|
Amazing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once pre-commit.ci is fully enabled then the pot should push the style fixes to this PR as a single commit. #360