Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 linting in ci and clean up style issues #230

Merged
merged 5 commits into from
May 26, 2020
Merged

Add flake8 linting in ci and clean up style issues #230

merged 5 commits into from
May 26, 2020

Commits on May 25, 2020

  1. Fix whitespace to match flake8.

    @QuLogic
    QuLogic committed May 25, 2020
    Configuration menu
    Copy the full SHA
    ca46448 View commit details
    Browse the repository at this point in the history

  2. Fix imports to appease flake8.

    @QuLogic
    QuLogic committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d8c2e67 View commit details
    Browse the repository at this point in the history

  3. Rename things to match pep8.

    @QuLogic
    QuLogic committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d8b3612 View commit details
    Browse the repository at this point in the history

  4. Simplify check for nbagg.transparent. 

    `rcParams` is a `dict`, so there's no need for the roundabout
`set(rcParams.keys())`.
    @QuLogic
    QuLogic committed May 25, 2020
    Configuration menu
    Copy the full SHA
    08a63b9 View commit details
    Browse the repository at this point in the history

  5. Add flake8 linting via reviewdog and GitHub Actions.

    @QuLogic
    QuLogic committed May 25, 2020
    Configuration menu
    Copy the full SHA
    e4e55f7 View commit details
    Browse the repository at this point in the history