Add User-Agent strings for Kiwi TCMS #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviuconcioiu
requested changes
Feb 23, 2024
atodorov
force-pushed
the
add_detection_for_kiwitcms
branch
from
e861be5
to
8fb80f3
Compare
|
@liviuconcioiu thanks for the suggestions and pointers to the test suite. Please review again! |
liviuconcioiu
requested changes
Feb 23, 2024
|
Also, you should convert the PR from draft. |
primarily so we can see our own stats display nicely in Plausible.io
atodorov
force-pushed
the
add_detection_for_kiwitcms
branch
from
8fb80f3
to
760926b
Compare
liviuconcioiu
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primarily so we can see our own stats display nicely in Plausible.io
Description:
Kiwi TCMS is using the Plausible.io API to collect anonymous stats like numbers of active installations and their versions out there in the wild. Adding our user-agent string so that the parser can recognize them and Plausible can show nicer stats.
Review