Skip to content

Commit

Permalink
Adds detection for Adobe Acrobat Reader and improves detection for va…
Browse files Browse the repository at this point in the history
…rious apps (#7867)

* Improves detection for Visual Studio Code
* Improves detection for GitHub Desktop
* Improves detection for Adobe NGL
* Adds detection for Adobe Acrobat Reader
* Adds detection for Fiddler Classic
* Move ZEIT ONLINE before generic
* Add website for Ehlel
  • Loading branch information
liviuconcioiu authored Oct 21, 2024
1 parent 3b87334 commit 8c100dd
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 9 deletions.
36 changes: 36 additions & 0 deletions Tests/Parser/Client/fixtures/mobile_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2159,3 +2159,39 @@
type: mobile app
name: ZEIT ONLINE
version: 2.2.7
-
user_agent: VSCode 1.94.2 (Code)
client:
type: mobile app
name: Visual Studio Code
version: 1.94.2
-
user_agent: git/2.45.1.windows.1 (GitHub Desktop/3.4.6; win32 x64)
client:
type: mobile app
name: GitHub Desktop
version: 3.4.6
-
user_agent: Mozilla / 3.0 (compatible; Adobe NGL; Windows)
client:
type: mobile app
name: Adobe NGL
version: ""
-
user_agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) ReaderServices/24.3.20180 Chrome/105.0.0.0 Safari/537.36
client:
type: mobile app
name: Adobe Acrobat Reader
version: 24.3.20180
-
user_agent: Acrobat/24.3.20180.6 NGL Client/1.38.0.10 (WINDOWS_64/10.0.19045.1)
client:
type: mobile app
name: Adobe Acrobat Reader
version: 24.3.20180.6
-
user_agent: 'Fiddler/5.0.20244.10953 (.NET 4.8; WinNT 10.0.19045.0; en-US; 8xAMD64; Auto Update; Full Instance; Extensions: APITesting, AutoSaveExt, EventLog, FiddlerOrchestraAddon, HostsFile, RulesTab2, SAZClipboardFactory, SimpleFilter, Timeline)'
client:
type: mobile app
name: Fiddler Classic
version: 5.0.20244.10953
26 changes: 18 additions & 8 deletions regexes/client/mobile_apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@
version: ''

# GitHub Desktop (https://desktop.github.com/)
- regex: 'GitHubDesktop/([\d\.]+)'
- regex: 'GitHub ?Desktop/([\d\.]+)'
name: 'GitHub Desktop'
version: '$1'

Expand Down Expand Up @@ -885,7 +885,7 @@
version: '$1'

# Visual Studio Code (https://code.visualstudio.com/)
- regex: 'Code/(\d+[\.\d]+)'
- regex: '(?:Code/|VSCode )(\d+[\.\d]+)'
name: 'Visual Studio Code'
version: '$1'

Expand Down Expand Up @@ -989,6 +989,11 @@
name: 'Opera News'
version: '$1'

# Adobe Acrobat Reader (https://get.adobe.com/reader/)
- regex: '(?:Acrobat|ReaderServices)/(\d+[\.\d]+)'
name: 'Adobe Acrobat Reader'
version: '$1'

# Adobe Creative Cloud (https://apps.apple.com/us/app/adobe-creative-cloud/id852473028)
- regex: 'CreativeCloud/(\d+[\.\d]+)'
name: 'Adobe Creative Cloud'
Expand Down Expand Up @@ -1382,7 +1387,7 @@
version: ''

# Adobe NGL
- regex: 'NGL Client/(\d+\.[\.\d]+)'
- regex: 'Adobe NGL|NGL Client/(\d+\.[\.\d]+)'
name: 'Adobe NGL'
version: '$1'

Expand Down Expand Up @@ -2545,6 +2550,16 @@
name: 'Mojeek'
version: ''

# Fiddler Classic (https://www.telerik.com/fiddler/fiddler-classic)
- regex: 'Fiddler/(\d+[\.\d]+)'
name: 'Fiddler Classic'
version: '$1'

# ZEIT ONLINE (https://www.zeit.de/administratives/zeit-online-app-ios-android)
- regex: 'ZONApp/(?:iOS|Android)/([\d\.]+)'
name: 'ZEIT ONLINE'
version: '$1'

# Electron generic apps
- regex: ' (?!(?:AppleWebKit|brave|Franz|Mailspring|Notion|Basecamp|Evernote|catalyst|ramboxpro|BlueMail|BeakerBrowser|Dezor|TweakStyle|Colibri|Polypane|VibeMate|(?:d|LT|Glass|Sushi|Flash|OhHai)Browser|Sizzy))([a-z0-9]*)(?:-desktop|-electron-app)?/(\d+\.[\d.]+).*Electron/'
name: '$1'
Expand All @@ -2559,8 +2574,3 @@
- regex: '(?!AlohaBrowser)([^/;]*)/(\d+\.[\d.]+) \((?:iPhone|iPad); (?:iOS|iPadOS) [0-9\.]+; Scale/[0-9\.]+\)'
name: '$1'
version: '$2'

# ZEIT-Online app https://www.zeit.de/administratives/zeit-online-app-ios-android
- regex: 'ZONApp/(?:iOS|Android)/([\d\.]+)'
name: 'ZEIT ONLINE'
version: '$1'
2 changes: 1 addition & 1 deletion regexes/device/mobiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42485,7 +42485,7 @@ Korax:
device: 'tv'
model: '$1'

# Ehlel
# Ehlel (https://ehlel.com/)
Ehlel:
regex: 'Ehlel[_ ]'
device: 'smartphone'
Expand Down

0 comments on commit 8c100dd

Please sign in to comment.