Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimx-fpsconfig loads wrong shape for DZ #525

Closed
GodlikeRU opened this issue Feb 3, 2018 · 3 comments
Closed

gimx-fpsconfig loads wrong shape for DZ #525

GodlikeRU opened this issue Feb 3, 2018 · 3 comments

Comments

@GodlikeRU
Copy link

GodlikeRU commented Feb 3, 2018

I found a bug in gimx-fpsconfig. If you save a config with shape="rectangle" then in gimx-fpsconfig dropdown shape will still be on circle value and it will overwrite actual config value on save.

Steps to reproduce:

  1. Make a config with shape="rectangle" and save it.
  2. Open it in gimx-fpsconfig - wrong shape value will be displayed, always Circle . If you hit Save then always Circle shape will be written to the config.

Using Gimx7.0beta6
Attaching config file to test
PS4_InfamousSecondSon_Godlike.zip

@GodlikeRU
Copy link
Author

GodlikeRU commented Feb 3, 2018

if(id.find("stick") == string::npos) { m_TempEvent.SetShape(""); }

code in GIMX/shared/gimxconfigeditor/src/XmlReader.cpp on line 259 is causing this

I do not know what purpose of this code is so im not removing it by myself. It checks if id contains "stick" but actually id contains rel_axis_2 in my case.

@matlo
Copy link
Owner

matlo commented Feb 3, 2018

Having a dead zone shape only makes sense for sticks, and at the beginning there was a single controller emulation (joystick, for ps3). The check should now be "if axis is not in rel_axis_0 to rel_axis_3".

@matlo matlo changed the title Gimx-fpsconfig does not load DZ shape values from config correctly gimx-fpsconfig loads wrong shape for DZ Feb 16, 2018
matlo pushed a commit that referenced this issue Feb 16, 2018
@matlo matlo closed this as completed Feb 16, 2018
@matlo
Copy link
Owner

matlo commented Feb 16, 2018

I just made a fix that also handles old configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants