-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATLAB Cache fixes #107
MATLAB Cache fixes #107
Conversation
I made a few more changes:
|
|
||
return actualToolCacheDir; | ||
} finally { | ||
process.env['RUNNER_TOOL_CACHE'] = defaultToolCacheRoot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this env variable changed above? I don't see it being used after it is change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I guess it's used by tc.cacheFile
behind the scenes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used inside GitHub's tc.cacheFile
code (and some of the other tool-cache functions) to locate the tool cache directory on the runner. We set it to the same location on D:
to create/ link the install directory then we restore it to it's default C:
location at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I guess it's used by
tc.cacheFile
behind the scenes?
Yeah exactly
Co-authored-by: Mark Cafaro <[email protected]>
This PR addresses 2 issues:
setup-matlab@v2
withcache: true
: Post setup fails randomly (not very often) #98actions/cache
andsetup-matlab@v2
#93