feat: adds a new method for requesting exercise permissions #167
Conversation
| @@ -34,12 +34,21 @@ class HealthConnectModule internal constructor(context: ReactApplicationContext) | |||
| @ReactMethod | |||
| override fun requestPermission( | |||
| permissions: ReadableArray, | |||
| providerPackageName: String, | |||
There was a problem hiding this comment.
Wasn't used so replaced it.
| recordType: 'ExerciseSession', | ||
| }, | ||
| ], | ||
| true |
There was a problem hiding this comment.
Added true here, hard to see the diff
| @@ -97,16 +97,20 @@ export function openHealthConnectDataManagement( | |||
| */ | |||
| export function requestPermission( | |||
| permissions: Permission[], | |||
| providerPackageName = DEFAULT_PROVIDER_PACKAGE_NAME | |||
| includeRoute?: boolean | |||
There was a problem hiding this comment.
Omitting this in arg in JS seems to cause issues atm:
Exception in native call
com.facebook.react.bridge.NativeArgumentsParseException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference (constructing arguments for HealthConnect.requestPermission at argument index 1)
| val exerciseRoute = HealthConnectPermissionDelegate.launchExerciseRouteAccessRequestDialog(recordId) | ||
| if (exerciseRoute != null) { | ||
| promise.resolve(ReactExerciseSessionRecord.parseExerciseRoute(exerciseRoute)) | ||
| } | ||
| else{ | ||
| promise.rejectWithException(ExerciseRouteAccessDenied()) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm getting some flaky results with exercises, everything returns permissions denied as in exerciseRoute is null and as is there is no way to know for certain if that's because there is no data or something is wrong with my patch/permissions etc. Maybe we should fetch the exercise record here and switch on ExerciseRouteResult to determine whether to request permission or reject with "NoDataException". Could go hand in hand with this.
|
Will look into this further this weekend |
Changes
requestPermissionto accept an optional flag that indicates requested permissions should includewrite-routepermission. Removed the unusedproviderPackageNamearg from the method as well.Issues
#34