Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Docker login for goreleaser-cross v1.19 #610

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

rekibnikufesin
Copy link
Contributor

Description

Goreleaser-cross v1.19.x dropped support for authenticating to Docker Hub using environment variables. This PR uses the Docker Login GitHub action to authenticate for pushing images

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Untested. Unable to test without building the release. Implementation based on review of changes in goreleaser-cross commit history as seen here

@rekibnikufesin rekibnikufesin requested a review from a team November 30, 2022 16:04
Copy link
Contributor

@djpolygon djpolygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Base: 56.85% // Head: 56.83% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (4d19cf5) compared to base (095ce5e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #610      +/-   ##
==========================================
- Coverage   56.85%   56.83%   -0.03%     
==========================================
  Files         598      598              
  Lines       69214    69215       +1     
==========================================
- Hits        39354    39338      -16     
- Misses      26497    26526      +29     
+ Partials     3363     3351      -12     
Impacted Files Coverage Δ
metrics/metrics.go 10.52% <0.00%> (-0.15%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
les/distributor.go 78.90% <0.00%> (-3.91%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
core/rawdb/chain_iterator.go 57.14% <0.00%> (-1.25%) ⬇️
rpc/client.go 83.72% <0.00%> (-1.17%) ⬇️
miner/worker.go 71.50% <0.00%> (-1.12%) ⬇️
trie/proof.go 73.59% <0.00%> (-1.06%) ⬇️
trie/trie.go 75.73% <0.00%> (-0.74%) ⬇️
eth/filters/api.go 41.13% <0.00%> (-0.71%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rekibnikufesin rekibnikufesin merged commit 3b4ff7d into qa Nov 30, 2022
@rekibnikufesin rekibnikufesin deleted the wbutton/goreleaser-docker-creds branch November 30, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants