Adding in Mumbai/Mainnet precursor deb packaging for tests to use dur… #590
Conversation
…ing upgrade(iterations to come)
Codecov ReportBase: 56.84% // Head: 56.84% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## qa #590 +/- ##
=======================================
Coverage 56.84% 56.84%
=======================================
Files 598 598
Lines 69210 69210
=======================================
Hits 39341 39341
Misses 26514 26514
Partials 3355 3355 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
.github/workflows/packager.yml
Outdated
| branches: | ||
| - 'main' | ||
| paths: | ||
| - '**' |
There was a problem hiding this comment.
These two are unnecessary I guess? We only need it the packager to run when new tags are created.
| run: rm -rf lib/systemd/system/bor.service | ||
|
|
||
| - name: Creating package for binary only bor | ||
| run: cp -rp packaging/deb/bor packaging/deb/bor-v0.3.0-beta-amd64 |
There was a problem hiding this comment.
It would be better to parameterize the version (v0.3.0) accordingly to the tag here, so we don't need to change it in multiple places when a new version is released in the future. I am okay with changing this in the future.
| @@ -0,0 +1,36 @@ | |||
| [Unit] | |||
There was a problem hiding this comment.
This file doesn't seem to be used anywhere else. Let's remove it if not used.
There was a problem hiding this comment.
Updated and removed
.github/workflows/packager.yml
Outdated
| - name: Confirming package built | ||
| run: ls -ltr packaging/deb/ | grep bor | ||
|
|
||
| - name: Release bor Packages |
There was a problem hiding this comment.
Can we make it a pre-release? A manual review is needed before actually releasing it.
|
|
||
| - name: Confirming package built | ||
| run: ls -ltr packaging/deb/ | grep bor | ||
|
|
There was a problem hiding this comment.
Do we plan to release rpm packages using alien?
| @@ -0,0 +1,318 @@ | |||
| name: packager | |||
There was a problem hiding this comment.
With packager.yml being added, we need to disable the release of gorelease in this line here. Otherwise, both workflows will try to create the same release.
.github/workflows/packager.yml
Outdated
| go-version: 1.19 | ||
| - name: Generate release tag | ||
| id: tag | ||
| run: echo "::set-output name=release_tag::bor_$(date +"%Y.%m.%d_%H-%M")" |
There was a problem hiding this comment.
The release name should match the release tag exactly (no date/time info should be included), as what we've been doing in the past: https://github.com/maticnetwork/bor/releases/
There was a problem hiding this comment.
Updated and now using tag
…on/v0.3.0packaging
…ing upgrade(iterations to come)
Description
Please provide a detailed description of what was done in this PR
Changes
Breaking changes
This change implements packaging for .deb and introduces profile concepts for installing for auto creating sentry nodes/validators. These packages rely on new hosts to be used on peers.
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
These tooling changes are per posv1 changes for the migration to more standardized debian packages. Other tooling changes will be in subsequent changes for clean up, rpm addition, and other packaging.