shuffle pending accounts in the transaction pool #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssandeep
approved these changes
Aug 24, 2022
temaniarpit27
approved these changes
Aug 25, 2022
|
@JekaMas can you please look into the CI failure? |
cffls
reviewed
Aug 25, 2022
| } | ||
|
|
||
| // ShuffleMap returns a shuffled slice of keys to iterate by | ||
| func ShuffleMap[K comparable, V any](m map[K]V) []K { |
There was a problem hiding this comment.
This isn't deterministically random I guess?
There was a problem hiding this comment.
As far as it uses crypto/rand, it isn't.
There was a problem hiding this comment.
This looks like a good explanation: https://stackoverflow.com/a/55925880
There was a problem hiding this comment.
Yeap, although it only depends on non cryptographically strong hash and a seed. The PR introduces cryptographically strong solution.
cffls
approved these changes
Aug 25, 2022
|
@JekaMas Can you please have a look at the CI ? Thank you ! |
|
@JekaMas CI is failing. Can you please look into this? |
|
I believe, we need to rethink whole idea of random ordering of transactions - ethereum/go-ethereum#21350 |
|
Will redo with proving tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents possible vulnerability with pre-mined accounts