Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, eth, internal, miner, params: enforce 30gwei for gas related configs in bor #1232

Closed
wants to merge 1 commit into from
Closed

core, eth, internal, miner, params: enforce 30gwei for gas related configs in bor #1232

wants to merge 1 commit into from

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Apr 29, 2024 •
edited
Loading

Description

This PR enforces the params txpool.pricelimit, miner.gasprice and gpo.ignoreprice to be set to 30 gwei.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@marcello33 marcello33 mentioned this pull request Apr 29, 2024
Merged
@marcello33 marcello33 closed this Apr 29, 2024
@marcello33 marcello33 deleted the v1.3.2-beta-candidate branch April 29, 2024 11:08
mh0lt pushed a commit to erigontech/erigon that referenced this pull request May 1, 2024
@marcello33
eth, txpool: enforce 30gwei for gas related configs for polygon (#10119)
d291552 
This PR enforces the params `txpool.pricelimit`, `miner.gasprice` and
`gpo.ignoreprice` to be set to 30 gwei when running `erigon` for Polygon
chains.

`bor` related PR: maticnetwork/bor#1232
yperbasis pushed a commit to erigontech/erigon that referenced this pull request May 1, 2024
@marcello33 @yperbasis
eth, txpool: enforce 30gwei for gas related configs for polygon (#10119)
6ec3bfe 
This PR enforces the params `txpool.pricelimit`, `miner.gasprice` and
`gpo.ignoreprice` to be set to 30 gwei when running `erigon` for Polygon
chains.

`bor` related PR: maticnetwork/bor#1232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcello33