Skip to content

Commit

Permalink
Add missing MSRV workflows for newer lib crates (microsoft#3042)
Browse files Browse the repository at this point in the history
  • Loading branch information
kennykerr authored and mati865 committed Jun 15, 2024
1 parent e6d2e56 commit 1b0abee
Show file tree
Hide file tree
Showing 9 changed files with 88 additions and 2 deletions.
File renamed without changes.
29 changes: 29 additions & 0 deletions .github/workflows/msrv-windows-core.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: windows-core

on:
pull_request:
push:
paths-ignore:
- '.github/ISSUE_TEMPLATE/**'
branches:
- master

env:
RUSTFLAGS: -Dwarnings

jobs:
check:
strategy:
matrix:
rust: [1.70.0, stable, nightly]
runs-on:
- windows-latest
- ubuntu-latest
runs-on: ${{ matrix.runs-on }}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Prepare
run: rustup update --no-self-update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
- name: Check
run: cargo check -p windows-core --all-features
File renamed without changes.
29 changes: 29 additions & 0 deletions .github/workflows/msrv-windows-registry.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: windows-registry

on:
pull_request:
push:
paths-ignore:
- '.github/ISSUE_TEMPLATE/**'
branches:
- master

env:
RUSTFLAGS: -Dwarnings

jobs:
check:
strategy:
matrix:
rust: [1.60.0, stable, nightly]
runs-on:
- windows-latest
- ubuntu-latest
runs-on: ${{ matrix.runs-on }}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Prepare
run: rustup update --no-self-update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
- name: Check
run: cargo check -p windows-registry --all-features
29 changes: 29 additions & 0 deletions .github/workflows/msrv-windows-result.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: windows-result

on:
pull_request:
push:
paths-ignore:
- '.github/ISSUE_TEMPLATE/**'
branches:
- master

env:
RUSTFLAGS: -Dwarnings

jobs:
check:
strategy:
matrix:
rust: [1.60.0, stable, nightly]
runs-on:
- windows-latest
- ubuntu-latest
runs-on: ${{ matrix.runs-on }}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Prepare
run: rustup update --no-self-update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
- name: Check
run: cargo check -p windows-result --all-features
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 1 addition & 2 deletions crates/libs/registry/src/key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,7 @@ impl Key {
ptr: *const u8,
len: usize,
) -> Result<()> {
let result =
unsafe { RegSetValueExW(self.0, pcwstr(name).as_ptr(), 0, ty, ptr, len.try_into()?) };
let result = RegSetValueExW(self.0, pcwstr(name).as_ptr(), 0, ty, ptr, len.try_into()?);

win32_error(result)
}
Expand Down

0 comments on commit 1b0abee

Please sign in to comment.