Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #80: Use specific versions of GitHub-hosted runners (e.g. ubuntu-22.04) for GitHub Actions workflows rather than -latest variants #81

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

sgilmore10
Copy link
Contributor

@sgilmore10 sgilmore10 commented Apr 26, 2024

Description

We have run into issues (e.g. #72) because the build.yml GitHub Actions workflows currently uses the -latest variants (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) of the Windows, macOS, and Linux GitHub-hosted runners.

The -latest variants are a "moving target" and can change at any time.

We should instead use specific versions of each platform like ubuntu-22.04 and windows-2022, rather than ubuntu-latest and windows-latest.

Changes

  1. Specify ubuntu-22.04 as the GitHub-hosted runner for the linux job
  2. Specify macos-14 as the GitHub-hosted runner for the mac job
  3. Specify windows-2022 as the GitHub-hosted runner for the windows job

@sgilmore10 sgilmore10 requested a review from kevingurney April 26, 2024 19:56
Copy link
Member

@kevingurney kevingurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kevingurney kevingurney merged commit a9fae73 into main Apr 26, 2024
3 checks passed
@kevingurney kevingurney deleted the GH-80 branch April 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants