Sre latex braille ext #1004
Sre latex braille ext #1004
Conversation
There was a problem hiding this comment.
I have checked the PR and it does seem to work as advertised. I did mark the changes we talked about of leaving nemeth as the default rather than euro, and of adding data- before latex and itemLatex attributes.
I also suggest a change for the saveI handling that doesn't use an array (it uses the call stack for that instead). That is just a suggestion if you want to use it.
Otherwise, I'm good with the PR.
components/mjs/a11y/util-pack.js
Outdated
| @@ -6,7 +6,7 @@ import './explorer/explorer.js'; | |||
| import {MathMaps} from '#js/a11y/mathmaps.js'; | |||
| import base from 'speech-rule-engine/lib/mathmaps/base.json' assert { type: 'json' }; | |||
| import en from 'speech-rule-engine/lib/mathmaps/en.json' assert {type: 'json' }; | |||
| import nemeth from 'speech-rule-engine/lib/mathmaps/nemeth.json' assert {type: 'json' }; | |||
| import euro from 'speech-rule-engine/lib/mathmaps/euro.json' assert {type: 'json' }; | |||
There was a problem hiding this comment.
As we discussed in our meeting, these need to either remain nemeth by default, or have an option that switches between the two.
|
One question I had: can you tell me the difference between the |
|
|
I've made the required changes. PTAL. |
Properly rebased version of #986 .
Thanks to @dpvc !