Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: feat: Adding commit filtering by path #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbarnett-jones
Copy link

Problem

We use github-tag-action to generate semver versions and then release notes for a number of projects. We are also using it in a monorepo with 2 different apps and this is where we're running into issues. Because github_tag_action looks at all the commits since the last tag we end up with a bunch of unrelated changes being considered e.g.

feat: Update frontend
feat: Add new python library 

Where ideally we'd only have one bump per app.

Solution

This is quick illustrative PR to explain how I might use the github-tag-action with a mono repo. In this change I added a path based filter to the getCommits - it's not wired through to the config / params that mean people can use it but I wanted to share this approach early to get some feedback before going any further.

Thoughts, comments, criticisms welcome.

sha: '4567',
},
];
// @ts-ignore
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tidy this up for a proper PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant