-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Maven Wrapper #220
Adds Maven Wrapper #220
Conversation
FYI that you don't want to commit the jarfile or the java, just the properties file and the wrapper scripts mvnw and mvnw.cmd |
thanks! |
637a464
to
4d93b40
Compare
Damn! I don't have any Travi-ci credits anymore :-( |
.gitignore
Outdated
@@ -26,3 +26,5 @@ nb-configuration.xml | |||
# OSX | |||
.DS_Store | |||
release-pom.xml | |||
|
|||
/.mvn/wrapper/maven-wrapper.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll want to add probably .mvn/wrapper/*.ja
to capture any named jar or java files in here, and then delete MavenWrapperDownloader.java
from this branch as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally I had to commit the file because of an error in Travis build:
--2021-09-08 21:03:25-- https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
Resolving repo.maven.apache.org (repo.maven.apache.org)... 199.232.192.215, 199.232.196.215
Connecting to repo.maven.apache.org (repo.maven.apache.org)|199.232.192.215|:443... connected.
ERROR: cannot verify repo.maven.apache.org's certificate, issued by 'CN=GlobalSign Atlas R3 DV TLS CA H2 2021,O=GlobalSign nv-sa,C=BE':
Unable to locally verify the issuer's authority.
To connect to repo.maven.apache.org insecurely, use `--no-check-certificate'.
4d93b40
to
aa086ec
Compare
aa086ec
to
de51c2f
Compare
719f751
to
e0e7676
Compare
e0e7676
to
08da7e5
Compare
Thanks @erikakuntar for the @travis-ci OSS credits! |
No description provided.