Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in a number of default ignores / remove one that was duplicated #179

Merged
merged 21 commits into from
Jul 25, 2020

Conversation

hazendaz
Copy link
Collaborator

No description provided.

hazendaz added 19 commits July 14, 2020 23:41
While not a standard, this is used quite often to store empty directories since git does not track directories but rather files.  In that case, ignore this file.
These if licensed are from the source projects and do not need relicensed.
some users have reported .idea being picked up.  This varies in setup from others with assumption its always at the root.  While that is appropriate, its possible a bad import could have it elsewhere.  To be save, ignore them all.
more typical these days is 'LICENSE' for the file to contain the full license and 'LICENSE_HEADER' to contain the header portion.  While there are certainly other legacy types like various case license.txt situations, those are legacy and probably not necessary to apply.
These don't work if extra stuff is added
@hazendaz
Copy link
Collaborator Author

This list probably could grow forever. I added most common ones I run into over 500+ repos at my day job. I'm sure there are many more and this is just the tip of the iceburg. Let me know what you think.

On the '.idea' one, I have been getting reports that 3.0 is licensing files in the folder so I suspect since this was only one not in the typical style as others it was likey some user error but see no harm in ensuring any .idea folder elsewhere is also ignored.

The xls entry was in the file already under docs.

@mathieucarbou
Copy link
Owner

Nice! Thanks a lot!
I will merge as soon as I see a successfy build.

mathieucarbou
mathieucarbou previously approved these changes Jul 15, 2020
@mathieucarbou mathieucarbou added this to the 4.0.rc2 milestone Jul 15, 2020
@mathieucarbou mathieucarbou added the is:enhancement Enhancement to an existing feature label Jul 15, 2020
@hazendaz
Copy link
Collaborator Author

@mathieucarbou Sorry I forgot to commas. Fixed that. I also added /node/ to be skipped. Same reason as node_modules. Thanks.

After this is in, is it possible for you to run a RC2? I have a number of people that want to try this out. More so for the .idea change as it was confirmed to me that idea will stick the idea folder into any folder that contains node/node modules so it will show up many times.

Beyond that I think I have a few more things but need to run some wide testing before I suggest more. Appreciate it!

@hazendaz
Copy link
Collaborator Author

@mathieucarbou Ping!

@mathieucarbou
Copy link
Owner

sounds good! thanks a lot!

@mathieucarbou mathieucarbou merged commit 5202973 into mathieucarbou:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants