emitting an event when status of timer changes #2
Conversation
|
emitting an event when status of timer changes this might helpful when we want to do something when timer status changes. |
emitting an event when status of timer changes
src/index.js
Outdated
| _stopped: 'stopped', | ||
| _running: 'running', | ||
| _paused: 'paused' | ||
| } |
There was a problem hiding this comment.
I think it's a good idea to group possible status values,
but I would prefer to remove this for now.
I might do this with Typescript at some point.
There was a problem hiding this comment.
I updated as per your suggestions.
Thanks!
src/index.js
Outdated
| this.changeStatus(status._running) | ||
| } | ||
|
|
||
| changeStatus (status) { |
There was a problem hiding this comment.
Can we add an underscore, to signal that this is an internal function:
_changeStatus (status) {
There was a problem hiding this comment.
I updated as per your suggestions.
Thanks!
src/index.js
Outdated
|
|
||
| changeStatus (status) { | ||
| this._status = status | ||
| this.emit('onChangeStatus', this._status) |
There was a problem hiding this comment.
I would like to rename the event, so it is attached by timer.on('statusChanged', ...)
| this.emit('onChangeStatus', this._status) | |
| this.emit('statusChanged', this._status) |
There was a problem hiding this comment.
I updated as per your suggestions.
Thanks!
updated as per suggestions
updated as per suggestion
|
I updated as per your suggestions. Thanks! |
|
@jbbpatel94 Thanks for the quick fixes 👍 Released it as |
No description provided.