N forms a semiring
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi8027
commented
Jun 8, 2023
|
|
||
| #[export] | ||
| HB.instance Definition _ := GRing.Nmodule_isComSemiRing.Build N | ||
| Nmult_assoc Nmult_comm Nmult_1_l Nmult_plus_distr_r N.mul_0_l isT. |
There was a problem hiding this comment.
Just a remark: The commutative ring instance for Z below uses Zmult_plus_distr_*l* but here I use Nmult_plus_distr_*r*. Naming inconsistency in the Coq standard library :/
proux01
reviewed
Jun 8, 2023
5 tasks
|
Could you add examples to test the new instances? |
|
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to add a proper support for semirings in Algebra Tactics (on top of math-comp/algebra-tactics#71), and then found that this semiring instance would be useful for that.
I also wanted to add morphism instances for
nat_of_binandbin_of_nat, but it requires math-comp/math-comp#1031. Maybe I can just copy instances fornatfrom math-comp/math-comp#1031 to here.