Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lee_addgt0Pr #992

Merged
merged 1 commit into from
Aug 8, 2023
Merged

lee_addgt0Pr #992

merged 1 commit into from
Aug 8, 2023

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

lee_adde can be proved using the corresponding lemma from ssrnum and
it might be less surprising to have the same naming scheme and a similar statement
using the reflect predicate

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jul 27, 2023
@affeldt-aist affeldt-aist added this to the 0.6.4 milestone Jul 27, 2023
@affeldt-aist affeldt-aist modified the milestones: 0.6.4, 0.6.5 Aug 5, 2023
@affeldt-aist affeldt-aist force-pushed the ereal_20230727 branch 2 times, most recently from 8cf2219 to 4f1d9bc Compare August 5, 2023 14:29
@affeldt-aist affeldt-aist requested a review from proux01 August 5, 2023 14:30
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Aug 5, 2023
@affeldt-aist affeldt-aist mentioned this pull request Aug 7, 2023
2 tasks
@affeldt-aist
Copy link
Member Author

NB: used in PR #1005 which has been approved

@affeldt-aist affeldt-aist merged commit 5b6d73c into math-comp:master Aug 8, 2023
@affeldt-aist affeldt-aist deleted the ereal_20230727 branch August 8, 2023 08:22
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Aug 9, 2023
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Aug 9, 2023
@proux01
Copy link
Collaborator

proux01 commented Aug 18, 2023

NB: used in PR #1005 which has been approved

Sure, I wasn't available to merge but this looks good.

@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Sep 5, 2023
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants