Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues 20230314 #874

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Issues 20230314 #874

merged 4 commits into from
Mar 27, 2023

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Mar 14, 2023 •
edited
Loading

Motivation for this change

fixes #866
fixes #867
fixes #868
fixes #865
fixes #864
fixes #862

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6.2 milestone Mar 14, 2023
@affeldt-aist
Copy link
Member Author

To rename the fields axX, I just reuse the name of the lemmas that are proved directly by these axioms, so the naming should be uncontroversial.

@affeldt-aist affeldt-aist added renaming/refactoring 🔧 This is about a renaming or refactoring in the library documentation 📝 This issue/PR is about documentation of the library / repository labels Mar 15, 2023
@CohenCyril CohenCyril added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Mar 27, 2023
CohenCyril
CohenCyril approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial indeed

@CohenCyril CohenCyril merged commit cc7b3e4 into math-comp:master Mar 27, 2023
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenCyril CohenCyril CohenCyril approved these changes

Assignees
No one assigned
Labels
documentation 📝 This issue/PR is about documentation of the library / repository renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Milestone
0.6.2
3 participants
@affeldt-aist @CohenCyril @proux01