Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products of Hausdorff spaces. #474

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Nov 12, 2021

A result from Munkres says products of Hausdorff spaces are Hausdorff. This proves that, although there is some annoyance with regard to dependent types. I end up using Eqdep_dec.eq_rect_eq_dec and pselect, to get the job done. It seems to work alright.

@affeldt-aist affeldt-aist added this to the 0.3.12 milestone Nov 14, 2021
theories/topology.v Outdated Show resolved Hide resolved
@affeldt-aist affeldt-aist modified the milestones: 0.3.12, 0.3.13 Dec 28, 2021
@zstone1
Copy link
Contributor Author

zstone1 commented Jan 19, 2022

Just wanted to check if there is anything else I should update here before Thursday.

@affeldt-aist
Copy link
Member

Since there is a definition, we maybe want to add documentation. I added some but you certainly have better wording. We can also maybe gain a few more lines by compressing scripts further.

@CohenCyril
Copy link
Member

Looks good to me, except for the name evaluator_dep which does not ring a bell to me (it says nothings about topology and evaluator is not an existing naming convention for application in the library).
I'd suggest prod_topo_apply or something like this.

fixing lines

Update theories/topology.v

using a better lemma to eliminate Eqdep_dec.eq_rect_eq_dec

Co-authored-by: Cyril Cohen <[email protected]>

doc, lint, compress
@zstone1
Copy link
Contributor Author

zstone1 commented Jan 20, 2022

Ah, that is a dramatic simplification for the continuity proof. Thanks! And I agree your suggested name is much improved. Now updated.

@affeldt-aist affeldt-aist merged commit 3d98b5f into math-comp:master Jan 21, 2022
CohenCyril added a commit that referenced this pull request Jan 21, 2022
- using a better lemma to eliminate Eqdep_dec.eq_rect_eq_dec

Co-authored-by: Cyril Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants