-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the definition of is_interval to rely on large inequalities #411
Conversation
I don't understand either. I did a rebase, and all of a sudden these commits were included in the branch. Maybe I goofed one of my rebase, and then I had to do force push, but people usually have to do a force push after a rebase, so that you are really working without a safety net at this point. Maybe the solution will be to remake the branch from scratch and cherry-pick the commits. I am not too fluent, but I may be able to repair that. |
Well, it looks like you rebased master on top of |
should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm 100% of the benefits of this change.
@affeldt-aist do you agree?
Yes, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking
4fb2c24
to
c53ffa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Cyril Cohen <[email protected]>
c53ffa9
to
8d0110c
Compare
The previous definition, based on strict inequalities, is less practical
The impact of this change has been tested against two other pull requests that use the
is_interval
concept