Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the count always from 1 #367

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

apobrt
Copy link
Collaborator

@apobrt apobrt commented Nov 19, 2023

close #366 : now the count starts from 1, so even if the start date and the finish date are equal, the difference is 1

@apobrt apobrt added this to the Release 2.3.0 milestone Nov 19, 2023
@apobrt apobrt self-assigned this Nov 19, 2023
@apobrt apobrt linked an issue Nov 19, 2023 that may be closed by this pull request
Copy link
Owner

@mateusz-bak mateusz-bak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to correct slowest/fastest book in statistics as well.

@mateusz-bak
Copy link
Owner

Also I think the average reading time must calculate from the duration + 1 if custom duration is not specified

@apobrt
Copy link
Collaborator Author

apobrt commented Jan 4, 2024

Ok, I think I'm done

refactor: Applied dart format
@mateusz-bak
Copy link
Owner

Looks good now, just added 1 commit with code format. Thank you

@mateusz-bak mateusz-bak merged commit e75cac6 into master Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reading Time incorrect, needs +1 offset
2 participants