Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.x] Fix serialize #92

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

lukecurtis93
Copy link
Contributor

@lukecurtis93 lukecurtis93 commented Apr 7, 2022

1.6 variant of: #91

Hey Mateus 👋 - I've had to do a bit of funkiness to get around how we're mocking this to get the producer class available to test appropriately. Please let me know if you have ideas on how to do this a bit cleaner 😊

@mateusjunges mateusjunges mentioned this pull request Apr 7, 2022
@mateusjunges mateusjunges self-assigned this Apr 7, 2022
@mateusjunges mateusjunges changed the base branch from v1.7.x to v1.6.x April 7, 2022 12:53
@mateusjunges mateusjunges merged commit 7ef6099 into mateusjunges:v1.6.x Apr 7, 2022
@mateusjunges
Copy link
Owner

@lukecurtis93 released on v1.7.2 and v1.6.5. Thank you!

@lukecurtis93
Copy link
Contributor Author

happy to help ! will be rolling this out in one of our internal systems soon so let me know if you have any improvements you think this package would benefit from 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants