Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.7.x] Added support for batch producing and handling batch of messages #86

Merged
merged 13 commits into from
Mar 23, 2022

Conversation

vsvp21
Copy link
Contributor

@vsvp21 vsvp21 commented Mar 16, 2022

No description provided.

@vsvp21 vsvp21 marked this pull request as ready for review March 18, 2022 12:55
@mateusjunges mateusjunges self-assigned this Mar 18, 2022
@mateusjunges mateusjunges changed the title Added support for batch producing and handling batch of messages [1.6.x] Added support for batch producing and handling batch of messages Mar 18, 2022
@mateusjunges
Copy link
Owner

I'm wondering why the tests pipeline is not running for this PR

@vsvp21
Copy link
Contributor Author

vsvp21 commented Mar 18, 2022

I'm wondering why the tests pipeline is not running for this PR

I have fixed it, forgot to add extra line at the end of configuration

src/BatchRepositories/BatchRepositoryInterface.php Outdated Show resolved Hide resolved
src/BatchRepositories/BatchRepositoryInterface.php Outdated Show resolved Hide resolved
src/Config/BatchConfigInterface.php Outdated Show resolved Hide resolved
src/Producers/Producer.php Outdated Show resolved Hide resolved
@mateusjunges
Copy link
Owner

@rtuin can you let me know your thoughts about this?

@vsvp21
Copy link
Contributor Author

vsvp21 commented Mar 21, 2022

@mateusjunges should I fix something else? Or it is fine for now?

@mateusjunges
Copy link
Owner

@vsvp21 i think its fine now. I've just removed some final classes. For my open source code, i assume users know they are responsible for writing tests for any overwritten behaviour. I'll review it one more time later today, and i'll let you know if there is any changes to be made.

@mateusjunges
Copy link
Owner

@vsvp21 one more thing: can you add a simple PHP doc block at least to the interface methods, explaining what each one is responsible for?

@vsvp21
Copy link
Contributor Author

vsvp21 commented Mar 21, 2022

@vsvp21 i think its fine now. I've just removed some final classes. For my open source code, i assume users know they are responsible for writing tests for any overwritten behaviour. I'll review it one more time later today, and i'll let you know if there is any changes to be made.

Okay, Thanks

@vsvp21
Copy link
Contributor Author

vsvp21 commented Mar 21, 2022

@vsvp21 one more thing: can you add a simple PHP doc block at least to the interface methods, explaining what each one is responsible for?

Yeah I'm gonna add it later today

@vsvp21
Copy link
Contributor Author

vsvp21 commented Mar 22, 2022

@mateusjunges I have added PHP doc blocks

@vsvp21 vsvp21 changed the title [1.6.x] Added support for batch producing and handling batch of messages [1.7.x] Added support for batch producing and handling batch of messages Mar 22, 2022
@vsvp21 vsvp21 changed the base branch from v1.6.x to v1.7.x March 22, 2022 04:21
@mateusjunges
Copy link
Owner

I'll merge this later today or tomorrow, i need to update my website to generate the docs from branch v1.7.x before. Thank you @vsvp21.

@mateusjunges mateusjunges merged commit 7e4a9b0 into mateusjunges:v1.7.x Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants