-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.7.x] Added support for batch producing and handling batch of messages #86
[1.7.x] Added support for batch producing and handling batch of messages #86
Conversation
I'm wondering why the tests pipeline is not running for this PR |
I have fixed it, forgot to add extra line at the end of configuration |
@rtuin can you let me know your thoughts about this? |
@mateusjunges should I fix something else? Or it is fine for now? |
@vsvp21 i think its fine now. I've just removed some final classes. For my open source code, i assume users know they are responsible for writing tests for any overwritten behaviour. I'll review it one more time later today, and i'll let you know if there is any changes to be made. |
@vsvp21 one more thing: can you add a simple PHP doc block at least to the interface methods, explaining what each one is responsible for? |
Okay, Thanks |
Yeah I'm gonna add it later today |
@mateusjunges I have added PHP doc blocks |
I'll merge this later today or tomorrow, i need to update my website to generate the docs from branch |
No description provided.